Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DigitalOcean, Moodle and Oracle icons #388

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

adpe
Copy link
Contributor

@adpe adpe commented Jul 5, 2023

What kind of change does this PR introduce?

Change which was discussed in #385

check at least one

  • Bugfix
  • Feature
  • Refactor
  • Other, please describe:

Validations

@antonreshetov
Copy link
Member

The files look unoptimized. Use svgo or other svg optimization utilities. Better yet, find a good collection of icons that follow svg best practices.

@antonreshetov
Copy link
Member

Big collection of icons https://icones.js.org/

@Faq
Copy link

Faq commented Jul 5, 2023

optimize svg https://jakearchibald.github.io/svgomg/

@antonreshetov
Copy link
Member

The icons should also be fitted into a square and have a margin. You can take any icon from https://github.com/massCodeIO/massCode/tree/master/src/renderer/assets/svg/icons as an example.

@adpe
Copy link
Contributor Author

adpe commented Jul 7, 2023

Got it! Thank you very much. Updated and added also a new one.

@adpe adpe changed the title feat: add DigitalOcean and Oracle icons feat: add DigitalOcean, Moodle and Oracle icons Jul 7, 2023
@antonreshetov antonreshetov merged commit 864e2f6 into massCodeIO:master Jul 18, 2023
@adpe adpe deleted the feat/folder-icons branch July 19, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants