Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webonchain cache management #1153

Closed
peterjah opened this issue Sep 7, 2023 · 3 comments · May be fixed by massalabs/massa-standards#125
Closed

Webonchain cache management #1153

peterjah opened this issue Sep 7, 2023 · 3 comments · May be fixed by massalabs/massa-standards#125
Labels
improvement_woc Potential improvements to consider for the next version of web on chain P2
Milestone
Web on chain

Comments

@peterjah
Copy link
Contributor

peterjah commented Sep 7, 2023

Context
Today we save zipped websites in MS user cache. the cache key is only based on the website SC address.
It does not have expiration time.
Thus, if the website is updated, or deleted we will continue serve it from the cache.

User flow
When i update my website i want the cache to be invalided for every user so they can see the latest version.

**Proposition **
Add a nonce system in the websiteStorer contract, that can be read and added to the cache key in massa station.
drawback: we will have to make 1 readSC call anytime
To mitigate this, we could add a possibility to add the nonce in the DNS contract, that will allow to have the nonce without extra sc call

QA testing

  • Upload a website, browse it (so it should be cached)
  • update or delete it
  • browse it again and ensure last version is rendered
@longgamma-massa
Copy link
Collaborator

@gregLibert ping on this to define priority of the task

@gregLibert
Copy link
Contributor

@gregLibert ping on this to define priority of the task

Current priority and milestone are fine

@peterjah peterjah linked a pull request Sep 27, 2023 that will close this issue
add webstorer nonce massalabs/massa-standards#125
Draft
@gregLibert
Copy link
Contributor

This topic should be tackled when we rework the web-on-chain. @SlnPons , please feel free to tag this issue for easier reference and refinement in the future, or not 😁.

@gregLibert gregLibert added the improvement_woc Potential improvements to consider for the next version of web on chain label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement_woc Potential improvements to consider for the next version of web on chain P2
Projects
None yet
Milestone
Web on chain
Development

Successfully merging a pull request may close this issue.

add webstorer nonce massalabs/massa-standards
3 participants
@gregLibert @peterjah @longgamma-massa