Correct test problems - [merged]

[massa-bot]

In GitLab by @damip

Merges damir_clarify_test_problems -> master

• I removed the yield hack
• I removed the test-threads=1 parameter because tarpaulin doesn't like it:
  • https://xd009642.github.io/2019/10/02/Tarpaulin-and-the-futures.html
  • Instrumentation address clash errors and segfaults xd009642/tarpaulin#190
  • Segfault During Testing with --with-threads=1 xd009642/tarpaulin#317
• to make tests run sequentially I used https://docs.rs/serial_test/0.5.1/serial_test/ Note that this is compatible with async tokio tests. Also note that I did a mass refactoring, but for many simple unit tests we could afford removing #[serial] to accelerate the pipeline.
• the test network::tests::scenarios::test_advertised_and_wakeup_interval was unstable because of badly chosen timings. I adjusted the timings for it to be robust
• I ran the pipeline 5+ times, it passed every time in less than 8min

[massa-bot]

In GitLab by @damip

requested review from @gterzian

[massa-bot]

In GitLab by @damip

assigned to @damip

[massa-bot]

In GitLab by @damip

@gterzian can you take a look and give me your opinion ?

[massa-bot]

In GitLab by @damip

changed the description

[massa-bot]

In GitLab by @damip

changed the description

[massa-bot]

In GitLab by @gterzian

Looks like it's working. Did you find out what the underlying reason for the timeouts was and that is is a more direct way of fixing it?

removed the test-threads=1 parameter

Where did you do this? I don't see this change, or the original parameter.

for many simple unit tests we could afford removing #[serial] to accelerate the pipeline

In the light of https://gitlab.com/massalabs/massa-network/-/merge_requests/318, to keep it simple we should either use multiple threads per tests(threaded tokio runtime), and run these tests serially, or use a single-threaded runtime(the default) with tests running in parallel. Using a threaded runtime and parallel tests is likely to make things more complicated with setting/sharing the serialization context.

[massa-bot]

In GitLab by @damip

approved this merge request

[massa-bot]

In GitLab by @damip

mentioned in commit 11ec775