Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When all participants leave the call, the patient isn't removed from the waiting queue #98

Closed
OmarZubaidi opened this issue Dec 1, 2023 · 5 comments

Comments

@OmarZubaidi
Copy link

See #95 AR point 3

@SamirOmarov
Copy link
Contributor

yeah we discussed this but not sure for full implementation, notes from slack:

We could try to detect when the user leaves the page / closes the tab, but that could have some drawbacks: https://stackoverflow.com/questions/3888902/detect-browser-or-tab-closing
Show them an alert telling them if they continue they will leave the call/waiting room?

the solution probably will be browser specific as well.

@ncgreene
Copy link
Contributor

ncgreene commented Dec 4, 2023

I'll attempt to summarize the problem:
We have trouble detecting participants leaving the waiting room because there are a variety of ways they could depart (clicking end call button, closing the tab, turning computer off, etc).

Something that might be worth looking into is server side notifications from twilio:
https://www.twilio.com/docs/video/api/status-callbacks

They allow HTTP callbacks to our API to notify us of actions happening in the application. It seems possible that we could update the encounter based on this information.

@SamirOmarov @OmarZubaidi what do you think of this? Any alternative solutions / feedback for this before we bring it to the ZapEHR team?

@alexwillingham
Copy link
Contributor

FWIW it is definitely a long term goal of this service to have Zap listen to status callbacks and other webhooks and automatically document details in the Encounter. Your frontend would probably have to poll the state of the Encounter to glean details from that I guess. Not really ideal?

@ncgreene
Copy link
Contributor

ncgreene commented Dec 4, 2023

Our FE already polls for the state of the Encounter

@ncgreene
Copy link
Contributor

ncgreene commented Dec 8, 2023

Moving out of MVP due to high LOE

@ncgreene ncgreene removed this from the December 15, 2023 milestone Dec 8, 2023
@saewitz saewitz closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants