-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does --video-params
disable default parameters and prevent target quality?
#662
Comments
I agree with both of your points, but would just add that |
Aside from fixing this, can you enlighten me as to what av1an is doing in this case? Is it currently possible to use target quality with a different svt-av1 preset? |
When av1an shows you
it just means that those are the "base" parameters it uses for encoding. Target quality mode decides on a CRF value for every chunk based on your target quality setting, which means your actual encoder parameters will be If you use custom Small edit: |
Thanks for the explanation! I definitely wasn’t able to intuit that from the output. |
I observed that if I run
av1an -e svt-av1 --target-quality=xx ....
the output includesBut if I run
av1an -e svt-av1 -v '--preset 10' --target-quality=xx ...
, the output just saysTo me, this implies that the presence of an explicitly specified
--video-params
is preventingav1an
from supplying its own parameters. My reading of the help output led me to assume that--video-params
would be in addition to to and not instead of the default per-encoder video parameters av1an used to get its job done.IMHO, av1an should always pass its video parameters unless the
-v
includes the same parameter (in which case the manually supplied parameter should win) - this would be for things like--preset
,--keyint
, etc. But if-v
included--crf
and--target-quality
was used, I would expect av1an to throw an error complaining that--crf
and--target-quality
cannot be used together.The text was updated successfully, but these errors were encountered: