Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class A Rule Simplification #36

Merged
merged 4 commits into from
Jan 20, 2014
Merged

Class A Rule Simplification #36

merged 4 commits into from
Jan 20, 2014

Conversation

zathras-crypto
Copy link
Contributor

Class A is only intended to provide backwards compatibility & is not used in any of the respective wallet implementations or for any features other than basic simple send. Thus the effort being expended on Class A does not correlate with its utility to the project and this pull is intended to put Class A to bed so we can move onto other more useful work.

As discussed with Tachikoma. Further details please see https://bitcointalk.org/index.php?topic=292628.msg4499342#msg4499342

Class A is only intended to provide backwards compatibility & is not
used in any of the respective wallet implementations or for any features
other than basic simple send.  Thus the effort being expended on Class A
does not correlate with its utility to the project and this pull is
intended to put Class A to bed so we can move onto other more useful
work.
…dress & that the two same valued outputs are in addition to the Exodus output.
@maran maran mentioned this pull request Jan 14, 2014
@maran
Copy link
Contributor

maran commented Jan 14, 2014

Overall +1; I replied in the forums since your explanation is there as well.

Tachikoma raised a valid point noting that users have control over
outputs but not seqnums, thus the human controlled aspect (outputs)
should take precedence in conflicts.  Accepted & modified to accomodate.
@ripper234
Copy link
Contributor

Let's merge this, it's been 6 days since this was created.

@maran
Copy link
Contributor

maran commented Jan 20, 2014

I think it should be good this way; I wish one of the other devs would have +1 or -1 this but I think we can always amend it later.

@zathras-crypto
Copy link
Contributor Author

Yes - would be good to get this merged as I think we're all now already
validating the edge transactions it allows. Bitoy also put in his +1, must
have been a mail to me rather than the group.

Thanks
Zathras

On Mon, Jan 20, 2014 at 11:23 PM, Maran notifications@github.com wrote:

I think it should be good this way; I wish one of the other devs would
have +1 or -1 this but I think we can always amend it later.


Reply to this email directly or view it on GitHubhttps://github.com//pull/36#issuecomment-32755239
.

maran pushed a commit that referenced this pull request Jan 20, 2014
Class A Rule Simplification
@maran maran merged commit ad83a78 into OmniLayer:master Jan 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants