Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should dispatch "slideend" on click #33

Open
tra opened this issue May 28, 2015 · 1 comment
Open

should dispatch "slideend" on click #33

tra opened this issue May 28, 2015 · 1 comment

Comments

@tra
Copy link

tra commented May 28, 2015

When clicking on the slider, the slider moves to the new position but does not dispatch a "slideend" event.

@tra tra changed the title should dispatch "dragend" on click should dispatch "slideend" on click May 28, 2015
@alspringsteen
Copy link

I wanted this feature as well. I don't know that everybody would want it, but it was definitely awkward having the data update when the slider is done being dragged, but not when clicked to a new position. You can get this if you dispatch "slide", but in my case it didn't make sense to update the data as frequently as that - I have a comparatively small step compared to the range of the slider, so it is essentially continuous.

For others who may want this, I did get the functionality I wanted by adding:
dispatch.slideend(d3.event, value);
to the end of the onClickHorizontal() and onClickVertical() functions.

I could see this as an option to turn on or off, and I could also see making the click event itself optional. It depends on how you want to direct the user to interact with the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants