Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidPrerelease should end in $ #86

Closed
jeremycarroll opened this issue Nov 12, 2018 · 1 comment
Closed

ValidPrerelease should end in $ #86

jeremycarroll opened this issue Nov 12, 2018 · 1 comment

Comments

@jeremycarroll
Copy link

I was reading the code and came across:

const ValidPrerelease string = `^([0-9A-Za-z\-]+(\.[0-9A-Za-z\-]+)*)`

in version.go. I don't know go, but it seems to me to mis-implement the metadata extension, in that this regex matches '0==='
i.e.

	matched, err := regexp.MatchString(`^([0-9A-Za-z\-]+(\.[0-9A-Za-z\-]+)*)`, "0===")

gives true, nil.

@mattfarina
Copy link
Member

Closing as this was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants