Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use newer version of mergo package #77

Closed
seaneagan opened this issue Feb 1, 2018 · 2 comments
Closed

Use newer version of mergo package #77

seaneagan opened this issue Feb 1, 2018 · 2 comments

Comments

@seaneagan
Copy link

seaneagan commented Feb 1, 2018 •
edited

sprig is currently locked to version 0.2.2 of mergo in glide.lock. Version 0.3.0 added this fix for merging slices correctly (deeply). Any chance of updating to 0.3.0? Here is a comparison between those versions for reference.
@mattfarina
Copy link
Member

@seaneagan We'd be up for the change. In addition to a straight update a test case that fails under the old method but passes in the new one would be useful for sprig. That would document as well as test the situation.

Are you up for the pull request?

@mattfarina
Copy link
Member

Sprig is not using the latest version of mergo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattfarina @seaneagan