-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpack require undefined when used alongside NamedModulesPlugin #29
Comments
Yep managed to reproduced it, I will try to find what's the issue here In the meantime, let me know if you find where it's coming from! |
Looks like it's caused by |
What version of NamedModulesPlugin/webpack are you using and what order should it be included in? |
I'm using webpack@2 and it doesn't have to do with the order I've got a failing test, I'm now trying to find where it's coming from :) |
So yeah, this issue is only happening on webpack@3 |
Released in 3.4.0 |
This fixed it for me. Thanks a ton! @mastilver |
@Connorelsea Which is better or worst? Depends on the context but the majority of the time, the first visit is slower than not using this plugin |
I am getting this error when attempting to integrate this into my webpack config. I am using this webpack config: https://github.com/Connorelsea/react-typescript-starter/blob/master/webpack.prod.js
The text was updated successfully, but these errors were encountered: