update to latest express; better error handling

masylum · Mar 10, 2011 · 01f8271 · 01f8271
1 parent cd0cc0d
commit 01f8271
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/lib/twitter_client.js b/lib/twitter_client.js
@@ -77,7 +77,7 @@ module.exports = function (api_key, api_secret, redirect) {
         parsedUrl.query.oauth_verifier,
         function (error, oauth_token, oauth_token_secret, additionalParameters) {
           if (error) {
-            callback(null, null);
+            callback(error, null);
           } else {
             callback(null, {oauth_token: oauth_token, oauth_token_secret: oauth_token_secret});
           }
@@ -95,8 +95,9 @@ module.exports = function (api_key, api_secret, redirect) {
             req.session.auth.twitter_oauth_token_secret = oauth_token_secret;
             req.session.auth.twitter_oauth_token = oauth_token;
             res.redirect("http://api.twitter.com/oauth/authorize?oauth_token=" + oauth_token);
+          } else {
+            callback(error, null);
           }
-          callback(null, null);
         }
       );
     }

diff --git a/test/client.js b/test/client.js
@@ -12,9 +12,9 @@ var express = require('express'),
       'http://twitter-js.com:3003/'
     ),
     app = express.createServer(
-      connect.bodyDecoder(),
+      connect.bodyParser(),
-      connect.cookieDecoder(),
+      connect.cookieParser(),
-      connect.session()
+      connect.session({ secret: 'yourSecret' })
     );
 
 app.set('views', __dirname);