Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard theme font has changed from sans-serif to serif #25

Closed
sesh opened this issue May 28, 2022 · 6 comments
Closed

Standard theme font has changed from sans-serif to serif #25

sesh opened this issue May 28, 2022 · 6 comments
Labels
question Further information is requested

Comments

@sesh
Copy link

sesh commented May 28, 2022

A recent change has changed the look and feel for the standard theme.

Checking in to see if this was intentional or not?

A quick bisect indicates this issue was introduced in this commit:
[d85bd95] move style into asset templates

Current rendering for me:
Example blog post with serif font and larger font size

Previous design:
Example blog post with sans-serif font and slightly smaller size

@sirodoht
Copy link
Member

Hi @sesh! Yes, this was an intentional change.

What do you think about it?

@sirodoht sirodoht changed the title Standard theme font has changed from sans-serif to sans Standard theme font has changed from sans-serif to serif May 29, 2022
@sirodoht sirodoht added the question Further information is requested label May 29, 2022
@sesh
Copy link
Author

sesh commented May 29, 2022

It's quite abrupt.

When I jumped online to share a post on Saturday morning my immediate thought was that some CSS had failed to load. The "Times New Roman" in your face look wasn't what I was expecting.

The old theme appealed to me in a bunch of ways. Perhaps a change like this is something that could be an option, or a different theme folks can choose (though, I realise that goes against some of your core goals). I'm sure I'll eventually come around to it but my initial reaction was that something was broken – perhaps not what you were aiming for.

@sirodoht
Copy link
Member

sirodoht commented Jun 1, 2022

Hey @sesh,

  1. I have introduced a 'Theme Sans-serif' option in settings, which will revert the previous look.

  2. I agree in not liking Times New Roman. I want to popularise the idea of people choosing their own fonts from their browser settings. I've been tweaking my own for a few months now and I enjoy looking my choice in the few websites that don't define a font (mataroa included) :D
    Here's how you can do that in Firefox & Chrome:
    https://support.mozilla.org/en-US/kb/change-fonts-and-colors-websites-use
    https://www.ghacks.net/2017/02/24/advanced-font-settings-for-google-chrome/

@yffr
Copy link

yffr commented Jul 26, 2022

this is a little unrelated, but will there be opportunities to add other CSS and theming customization? i appreciate the optional email notifications but would love an option to disable the RSS option and customize link colors. if not, no problem - thanks for the work put into this project thus far, it's fantastic

@sirodoht
Copy link
Member

Hey @yffr!

We had a similar discussion at #3.

Essentially, there are no plans to enable users to add custom CSS because that would mean that they would have to spend time deciding what style they want their blog to have. This is in contrast to our philosophy, which is very narrow.

However, one can add a few allowed inline CSS styles (a limited set here), for example, when one makes a table and want to make everything fit in one line.

@sesh
Copy link
Author

sesh commented Jan 4, 2023

Closing this because it was an intentional change, and additional themes have been added.

Feel free to re-open it if you wanted to keep it around for some other reason.

@sesh sesh closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

3 participants