Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Improve package version detection using jq, python and node #107

Closed
matchai opened this issue Nov 21, 2018 · 1 comment
Closed

Improve package version detection using jq, python and node #107

matchai opened this issue Nov 21, 2018 · 1 comment

Comments

@matchai
Copy link
Owner

matchai commented Nov 21, 2018

The following improvement made to the package section in spaceship should be ported over to spacefish to improve the accuracy of the version shown.

🐟 spacefish-bot β€” Pull request copied from: spaceship-prompt/spaceship-prompt#441.

grep solution to fetch version package.json was hacky and wasn't always returning expected values. Now using other fallback methods to get version information, Following discussions from spaceship-prompt/spaceship-prompt#439

Changes

  • Fetch version information with jq with fallback to python and node.
  • Gracefully exit from the section if no version information is found or is undefined from package.json

Fix spaceship-prompt/spaceship-prompt#439
Close spaceship-prompt/spaceship-prompt#552
Close spaceship-prompt/spaceship-prompt#553

@matchai matchai added the Type: Bug Fix an existing bug label Nov 21, 2018
@spacefish-bot spacefish-bot bot changed the title #441 Improve package version detection using jq, python and node Nov 21, 2018
@tiffafoo
Copy link
Collaborator

tiffafoo commented Mar 8, 2019

This was done in #143 πŸŽ‰

@tiffafoo tiffafoo closed this as completed Mar 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants