You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Current Behavior
With the recently released Docker 18.09 (Version 2.0.0.0-mac78), I experience that the Kubernetes section is always enabled. The reason for that is Kubernetes is now included with Docker, and the kubectl command is therefore always present. The current check is only wether if the command is present or not.
Expected Behavior
The prompt added with #76 should only be visible when needed. Inside a config folder (Dockerfile, etc. Don't know how Kube works.)
Environment
Spacefish version: [the output of echo $SPACEFISH_VERSION]
1.9
Fish version: [the output of fish --version]
fish, version 2.7.1-1181-g18a163dc
Fish plugin manager: [e.g. oh-my-fish, fisher, fin]
fundle
Operating system: [e.g. OSX 10.13.4, Windows 10]
macOS Mojave
Possible Solution
Only load the section when needed.
Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.
The text was updated successfully, but these errors were encountered:
MindTooth
changed the title
kubectl included with Docker 18.11 set kubectl prompt to always enabled
Kubernetes included with Docker 18.09 set kubectl-section to always be enabled
Nov 23, 2018
MindTooth
changed the title
Kubernetes included with Docker 18.09 set kubectl-section to always be enabled
Kubernetes included with Docker 18.09 sets the kubectl-section to always be enabled
Nov 23, 2018
It looks to me like this same issue would occur on spaceship with the latest version of Docker.
I think it would be best if we let them address it first.
Upon further investigation, it looks like this same issue doesn't occur on Spaceship ZSH 3.8.1 (latest right now). I'll see if I can find the cause of the problem. 🕵️
Bug Report
Current Behavior
With the recently released Docker 18.09 (Version 2.0.0.0-mac78), I experience that the Kubernetes section is always enabled. The reason for that is Kubernetes is now included with Docker, and the
kubectl
command is therefore always present. The current check is only wether if the command is present or not.Expected Behavior
The prompt added with #76 should only be visible when needed. Inside a config folder (Dockerfile, etc. Don't know how Kube works.)
Environment
echo $SPACEFISH_VERSION
]1.9
fish --version
]fish, version 2.7.1-1181-g18a163dc
fundle
kitty
macOS Mojave
Possible Solution
Only load the section when needed.
Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.
![screenshot 2018-11-23 at 16 17 03](https://user-images.githubusercontent.com/33870508/48950384-3d93b780-ef3b-11e8-8208-8bc53998bc8e.png)
The text was updated successfully, but these errors were encountered: