Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Kubernetes included with Docker 18.09 sets the kubectl-section to always be enabled #111

Closed
MindTooth opened this issue Nov 23, 2018 · 3 comments · Fixed by #122
Closed

Comments

@MindTooth
Copy link

Bug Report

Current Behavior
With the recently released Docker 18.09 (Version 2.0.0.0-mac78), I experience that the Kubernetes section is always enabled. The reason for that is Kubernetes is now included with Docker, and the kubectl command is therefore always present. The current check is only wether if the command is present or not.

Expected Behavior
The prompt added with #76 should only be visible when needed. Inside a config folder (Dockerfile, etc. Don't know how Kube works.)

Environment

  • Spacefish version: [the output of echo $SPACEFISH_VERSION]
    1.9
  • Fish version: [the output of fish --version]
    fish, version 2.7.1-1181-g18a163dc
  • Fish plugin manager: [e.g. oh-my-fish, fisher, fin]
    fundle
  • Terminal emulator: [e.g. iTerm, Hyper, Terminator]
    kitty
  • Operating system: [e.g. OSX 10.13.4, Windows 10]
    macOS Mojave

Possible Solution

Only load the section when needed.

Additional context/Screenshots

Add any other context about the problem here. If applicable, add screenshots to help explain.
screenshot 2018-11-23 at 16 17 03

@MindTooth MindTooth changed the title kubectl included with Docker 18.11 set kubectl prompt to always enabled Kubernetes included with Docker 18.09 set kubectl-section to always be enabled Nov 23, 2018
@MindTooth MindTooth changed the title Kubernetes included with Docker 18.09 set kubectl-section to always be enabled Kubernetes included with Docker 18.09 sets the kubectl-section to always be enabled Nov 23, 2018
@matchai matchai added the Type: Bug Fix an existing bug label Nov 25, 2018
@matchai
Copy link
Owner

matchai commented Nov 25, 2018

It looks to me like this same issue would occur on spaceship with the latest version of Docker.
I think it would be best if we let them address it first.

++ @salmanulfarzy in case they want to open an issue

@Snuggle Snuggle added the Upstream Issue Issue also affecting upstream. May need fixing there, first. label Nov 25, 2018
@matchai
Copy link
Owner

matchai commented Nov 30, 2018

Upon further investigation, it looks like this same issue doesn't occur on Spaceship ZSH 3.8.1 (latest right now). I'll see if I can find the cause of the problem. 🕵️

@matchai matchai removed the Upstream Issue Issue also affecting upstream. May need fixing there, first. label Nov 30, 2018
@matchai
Copy link
Owner

matchai commented Nov 30, 2018

Looks I missed a bit of logic when reading over the spaceship implementation. 😅
Should be quickly fixed with the upcoming PR.

Sorry for the wait!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants