SPACEFISH_GIT_STATUS_SHOW is never checked

[hrvoj3e]

SPACEFISH_GIT_STATUS_SHOW can not be turned off - check this variable and return if false

Description

Motivation and Context

Improves #154

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

• I have tested using MacOS
• I have tested using Linux

Checklist:

• I have checked that no other PR duplicates mine
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have updated the tests accordingly.

[hrvoj3e]

https://github.com/denysdovhan/spaceship-prompt/blob/master/sections/git_status.zsh

spaceship_git_status() {
  [[ $SPACESHIP_GIT_STATUS_SHOW == false ]] && return

  spaceship::is_git || return
...
...

[matchai]

Hey @hrvoj3e. Thank you for the contribution! 😄
That's a great bug you caught. Before we have this merge in, could you please add a test for this config option so that we can catch future regressions?

The appropriate test file is here: https://github.com/matchai/spacefish/blob/master/tests/__sf_section_git_status.test.fish

[hrvoj3e]

Is this OK? 8761549

[matchai]

Yes, looks great!
Thank you for your contribution. 😄

[matchai]

🎉 This PR is included in version 2.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀