Return more than 10 rows bug

[mauxtin]

Shouldn't these two return the same result?

   $results = Product::search('*')->get(); // ok - returns collection with 10 products

   $results = Product::search('*', function (Client $client, Search $body) {
      $body->setSize(100);
      $client->search(['index' => 'products', 'body' => $body->toArray()]);
   })->get(); // returns empty collection

At first the second query returns an error

Argument 1 passed to Matchish\ScoutElasticSearch\ElasticSearch\EloquentHitsIteratorAggregate::__construct() must be of the type array, null given, called in \xxx\vendor\matchish\laravel-scout-elasticsearch\src\Engines\ElasticSearchEngine.php on line 106

which I solved by editing the EloquentHitsIteratorAggregate constructor from

public function __construct(array $results, callable $callback = null)

to

public function __construct(?array $results, callable $callback = null)

(I did not make a PR for this since I just started working with the package and I am not sure if this is actually a bug. Let me know if you need me to make a quick PR)

[matchish]

Thanks for the issue. I think return statement should solve the issue

   $results = Product::search('*', function (Client $client, Search $body) {
      $body->setSize(100);
      return $client->search(['index' => 'products', 'body' => $body->toArray()]);
   })->get(); // returns empty collection

So probably example in README has mistake
Feel free to make PR to fix README if return statement will solve the issue