Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 10 Support #235

Closed
adrianpaiva1 opened this issue Feb 15, 2023 · 7 comments
Closed

Laravel 10 Support #235

adrianpaiva1 opened this issue Feb 15, 2023 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@adrianpaiva1
Copy link

No description provided.

@adrianpaiva1 adrianpaiva1 added the enhancement New feature or request label Feb 15, 2023
@matchish matchish added the help wanted Extra attention is needed label Feb 15, 2023
@matchish
Copy link
Owner

https://github.com/laravel/scout/pull/696/files

Looks like not too much changes needed. Feel free to send a PR

@hkulekci
Copy link
Contributor

We need to upgrade the "orchestra/testbench": "^6.18", also for this support. I did not check yet why we depend on this library. I am looking for this upgrade if you don't look @adrianpaiva1

@matchish
Copy link
Owner

orchestra/testbench package to have tests that depends on laravel. this repo laravel package that's why we have it. I think we can update, I don't see any blockers for it

@matchish
Copy link
Owner

I believe we can switch to "orchestra/testbench": "^6.17|^7.0|^8.0", the same that laravel/scout use

@matchish
Copy link
Owner

@adrianpaiva1 Released. Could you give a feedback? Many thanks to @hkulekci

@vrusua
Copy link
Contributor

vrusua commented Mar 3, 2023

@matchish Hi Sergey,
the scout 10.0 is released, could you please update dependencies from laravel/scout: ^8.0|^9.0|^10.
PS: I've added PR #242 just FYI.
Thanks.

@matchish
Copy link
Owner

matchish commented Mar 6, 2023

@vrusua thanks for the PR. released

@matchish matchish closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants