Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uppercase prefix for kilo- and mega- #28

Merged
merged 1 commit into from Jun 5, 2015
Merged

Use uppercase prefix for kilo- and mega- #28

merged 1 commit into from Jun 5, 2015

Conversation

JIghtuse
Copy link
Contributor

@JIghtuse JIghtuse commented Apr 8, 2015

Using 'mb/s' is confusing - user can thought it means 'millibit'. Since
we have a 'full notation', it is possible to use 'b' for bits and 'B'
for bytes. Let's use uppercase letter for prefix in this notation.

See also: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=781488

Using 'mb/s' is confusing - user can thought it means 'millibit'. Since
we have a 'full notation', it is possible to use 'b' for bits and 'B'
for bytes. Let's use uppercase letter for prefix in this notation.

See also: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=781488
@monsta
Copy link
Contributor

monsta commented Jun 5, 2015

Have you ever seen "millibits" anywhere? :)

@JIghtuse
Copy link
Contributor Author

JIghtuse commented Jun 5, 2015

@monsta no, but still, using standardized units adds some readability. 😌

@monsta
Copy link
Contributor

monsta commented Jun 5, 2015

Ok this is a minor change anyway, let's merge it.

monsta added a commit that referenced this pull request Jun 5, 2015
Use uppercase prefix for kilo- and mega-
@monsta monsta merged commit 413db8f into mate-desktop-legacy-archive:master Jun 5, 2015
@piotrjurkiewicz
Copy link

With mb -> Mb you were right.

But kb should have stayed as it was. Small k should be used when kilo is 1000. Big K or Ki should be used when kilo is 1024. In this case, when bits == true, kilo is 1000 (see line 418). So small letter k should be used.

@JIghtuse
Copy link
Contributor Author

JIghtuse commented Jun 8, 2015

@monsta should I send another PR to fix issue with 'k'?

@monsta
Copy link
Contributor

monsta commented Jun 8, 2015

I reverted kilo- prefix to lowercase in 908f931. Hope it's ok for you guys :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants