Migrate from intltool to gettext #512
Conversation
|
I fixed @monsta
|
|
Ok, try #513 for a fix. |
Sometimes a look at gedit repo at gitlab helps. I guess gedit is ported to gettext. |
|
Lines 762 to 768 in a6fe4f4 Typing error make it.po fail. |
|
Sadly, gedit droped the tag list plugin. |
|
I don't agree with removing |
#513 will drop translations for other languages eg. |
|
Rebase with fixed |
|
if you remove
It doesn't break other translations, it just add a little more work to translators, and I think they are happy doing the job. Is acceptable to have wrong translations in two languages forever?
I just was waiting for #513 to be merged @mate-desktop/core-team I think we can vote, do you like to remove |
|
I think we should do things with the right way. If it is wrong, then we will correct it instead of ignoring it. |
|
@mate-desktop/core-team I think the right way, to make everybody happy, is don't change ngettext code, fix it at transifex, and ignore de wrong error in transifex. |
|
Sigh, I only asked to test the other way of fixing the problem in PR. Edit: and unsubscribed |
|
I fixed but I couldn't fix ukranian (uk)
I click in Save changes, but it never saves. I tried to contact to transifex team, but they doesn't reply by mail, and I don't know how to register to open new thread in https://community.transifex.com/c/translators-community |
List of languages with one of the plural forms in |
yetist
changed the title
|
This PR is done, waiting for the fix of ru.po and uk.po. |
|
@mate-desktop/core-team maybe we must to migrate from |
|
transifex issue was reported in 2013! here: transifex/transifex-old-core#287 |
|
Check out README.md there, that repo isn't maintained for years... |
|
oops, yes, seems the issue never will be fixed in transifex |
|
Maybe try https://www.transifex.com/contact/? |
|
The job is done! I downloaded the .po file from transifex, modify, and later I uploaded it.
@monsta Please check if PR is ok for you |
|
It's ok as a quickfix, but the same can happen with other languages I've mentioned when they'll get the translation for these strings. |
There was a problem hiding this comment.
@yetist: same as in mate-desktop/eom#245 (comment), make distclean doesn't remove the generated files. It worked with intltool. Now I have to remove all of them manually, otherwise nothing is built in po subdir on the next builds.
Yes, and we can again download-fix-upload, I think change code to make happy transifex which doesn't work as expected is a bad idea. In the future, if transifex don't like to fix the issue we can consider alternatives (maybe https://crowdin.com ?) |
Not our problem, there is discussion here. |
|
@yetist I see this warning in logs:
|
|
@yetist: oh, great. So the discussion went nowhere and then https://bugs.debian.org/400453 was archived in 2007... Ok, I get it about |
|
@yetist pluma-plugin.desktop.in has an |
|
offtopic on offtopic off |
|
Hmm, this happens when i select the tag-list plugin in sidebar. This doesn't happen without PR. |
When xml file is generated using intltool, the resulting xml file deletes the comment line, but when using gettext, it keeps the comment line.
When using intltool, the taglist creates a big xml file containing the
local translation string, so that it has to be compressed.
It looks like this:
```
<TagGroup sort="true" name="XHTML 1.0 - Tags">
<Tag name="Abbreviated form">
...
</Tag>
<Tag name="...">
...
</Tag>
...
</TagGroup>
<TagGroup xml:lang="af" sort="true" name="XHTML 1.0 - Tags">
<Tag name="Afgekorte vorm" xml:lang="af">
...
</Tag>
<Tag name="..." xml:lang="af">
...
</Tag>
...
</TagGroup>
<TagGroup xml:lang="..." sort="true" name="XHTML 1.0 - Tags">
</TagGroup>
```
Obviously, it wastes space and download bandwidth.
When switch from intltool to gettext, it does not generate a similar
huge xml file. It only get the translate string into pot file from the
xml file, and the original xml file has not changed.
This patch let taglist-plugin read the local translation string directly
from the mo file, so that it can work as before.
TODO: we need to improve and optimize the taglist plugin code and
drop some extra code.
There was a problem hiding this comment.
LGTM,
taglist-plugin warnings are fixed now.
./autogen.sh && ./makepot
diff -uprN pluma-master.pot pluma.pot > diff-pot-files.diff
shows me that all translations are there, and all desktop files have translator hints.
Installation/uninstallation to /usr/local/share/locale/*/LC_MESSAGES/*.mo works fine.
All necessary files are in a tarball generated by distcheck.
I don't mind about distclean remarks because we won't use it with meson build system in future.
... ready to go.
Thanks.
|
Approved by 2 peoples is enough. |
This PR is not finished, please don't merge it.
I am having trouble and need some help. I don't know how to write a correct
.itsfile for some xml files. These files inplugins/taglistdirecoty, named*.tags.xml.in, for example:I don't know how to make
nameproperties inTagtranslatable, the string isAbbreviated form.@mate-desktop/core-team @mate-desktop/contributors
Who can help? Or do we need to modify the code to change the xml file structure?
BTW, {it,ru,uk}.po has errors, I temporarily disable them.