[FreeBSD] strict_fstream.hpp:77:26: error: invalid conversion from 'int' to 'char*'

[yurivict]

The LBANN project that uses zstr fails to compile:

In file included from /usr/local/include/zstr.hpp:15,
                 from /disk-samsung/freebsd-ports/misc/lbann/work/lbann-0.102-254-g2e3012a9a/include/lbann/data_readers/sample_list_impl.hpp:57,
                 from /disk-samsung/freebsd-ports/misc/lbann/work/lbann-0.102-254-g2e3012a9a/include/lbann/data_readers/data_reader_sample_list_impl.hpp:32,
                 from /disk-samsung/freebsd-ports/misc/lbann/work/lbann-0.102-254-g2e3012a9a/src/data_readers/data_reader_smiles.cpp:29:
/usr/local/include/strict_fstream.hpp: In function 'std::string strict_fstream::strerror()':
/usr/local/include/strict_fstream.hpp:77:26: error: invalid conversion from 'int' to 'char*' [-fpermissive]
   77 |     char * p = strerror_r(errno, &buff[0], buff.size());
      |                ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                          |
      |                          int

gcc-11
FreeBSD 13.1

[ferdymercury]

Seems similar to https://stackoverflow.com/questions/41953104/strerror-r-is-incorrectly-declared-on-alpine-linux

[ferdymercury]

@sandsmark fixed this part of the code in the past

[ferdymercury]

Does it get solved if you add the following line before #include <zstr.hpp>?

#define __MUSL__

[yurivict]

Does it get solved if you add the following line before #include <zstr.hpp>?

#define MUSL

Yes

[ferdymercury]

If you want, provide a PullRequest, where you add in the https://github.com/mateidavid/zstr/blob/master/src/strict_fstream.hpp wherever MUSL appears, paste also the variable FreeBSD
so that you do not need to do the define-MUSL trick.

[yurivict]

I patched the FreeBSD port to add defined(__FreeBSD__)next to the defined(__APPLE__).
You can just do the same in the project.