Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated bash completion scripts are set executable #104

Closed
sgallagher opened this issue Jul 17, 2019 · 0 comments · Fixed by #105
Closed

Generated bash completion scripts are set executable #104

sgallagher opened this issue Jul 17, 2019 · 0 comments · Fixed by #105
Labels
Milestone

Comments

@sgallagher
Copy link
Contributor

Bash completion scripts should have permissions 0644, but they are generated by argbash as 0755 and have #!/usr/bin/bash at the top (notably, this includes the generated completion script for argbash itself).

This can actually cause problems for RPM packaging, as it will add a runtime dependency on /usr/bin/bash if it sees an executable script with such a hashbang in the %files payload.

Bash completion scripts are always loaded by the bash binary and serve no purpose when executed directly, so there really isn't any advantage to making them executable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants