Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Typo in Generated Script comments for running argbash #97

Closed
EdwardOst opened this issue Jun 29, 2019 · 4 comments · Fixed by #102
Closed

Minor Typo in Generated Script comments for running argbash #97

EdwardOst opened this issue Jun 29, 2019 · 4 comments · Fixed by #102
Labels
Milestone

Comments

@EdwardOst
Copy link

When I create a new script with argbash-init in fully decoupled mode it includes a helpful comment for running argbash on the resulting files to generate the script.

argbash-init -s -s --mode=full --pos positional-arg --opt option --opt-bool print myscript

Generates this comment in myscript

# Run 'argbash --library "myscript-parsing.sh" -o "myscript-parsing.sh"

But I think it is slightly wrong. I believe the comment should read

# Run 'argbash --library "myscript-parsing.m4" -o "myscript-parsing.sh"

The primary argument should be the .m4 specification file, not the script itself. (At least when running in fully decoupled mode.)

Also, it would be good to use the --strip user-content rather than --library to avoid the warning message.

@matejak
Copy link
Owner

matejak commented Jul 1, 2019

Please check out your description again, the actual and suggested comments are the same, I believe that there is a typo.

@EdwardOst
Copy link
Author

The suggested comment reference

myscript-parsing.m4

whereas the actual current comments specify

myscript-parsing.sh

@matejak
Copy link
Owner

matejak commented Jul 3, 2019

Oh, I see, thanks!

@matejak matejak added the bug label Jul 3, 2019
@matejak matejak added this to the 2.9.0 milestone Jul 3, 2019
@matejak
Copy link
Owner

matejak commented Jul 8, 2019

@EdwardOst Could you please check the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants