Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executables are not found if they are inside folders listed in VS Code files.exclude option #113

Closed
deitry opened this issue Jul 23, 2019 · 8 comments

Comments

@deitry
Copy link

deitry commented Jul 23, 2019

I have test executables inside build/. I added this folder to files.exclude in order to hide it from explorer tree, but my test executables are also become hidden. Executables are not shown even if I pass relative or absolute path instead of globbing pattern.

Is there a possibility to resolve executables pattern even if it intersects with 'files.exclude'?

@matepek
Copy link
Owner

matepek commented Jul 23, 2019

I'm using the findFiles endpoint to query files. According to the documentation if the second parameter is null, it should not use the default exclusion pattern. I interpret this that it should work, because I am passing null as second parameter.

I might misinterpret the documentation or there is vscode bug.

@deitry
Copy link
Author

deitry commented Jul 23, 2019

Thanks for the quick reply!
I found related issue: microsoft/vscode#48674
It seems that files.exclude IS default exclusion path.

I guess the easiest way to have both features would be to add exclude option to this extension which would be passed instead of null.

@matepek
Copy link
Owner

matepek commented Jul 23, 2019

Nore that “undefined” and “null” are different values in JavaScript.
Since you are talking about “undefined”, you might missed that. If not then I am missing something, please explain what do you mean.

@deitry
Copy link
Author

deitry commented Jul 23, 2019

I'm bad in JS so I talk only about files detection dependency on files.exclude option. undefined is discussed in the VS Code issue which I suppose to be related.

I guess this issue could be called a feature request to have independent exclude configuration entry.

@matepek
Copy link
Owner

matepek commented Jul 23, 2019

Disagree:

When undefined only default excludes will apply, when null no excludes will apply.

(See doc)
According to the documentation null would work, and I using it. So if it is not working it is a vscode bug related to null, not undefined.

@deitry
Copy link
Author

deitry commented Jul 23, 2019

Oh, I get it now.

@deitry
Copy link
Author

deitry commented Jul 24, 2019

microsoft/vscode@c467419

When null, no search excludes will apply, but files.exclude will still apply.

This is current behaviour, but I hope there would be discussion on changing it:
microsoft/vscode#77813

@matepek
Copy link
Owner

matepek commented Jul 24, 2019

For default exclude there is undefined value.

They reopened your issue 👍

I will close this if you don't mind and hope that vscode fixes its API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants