Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip: dark theme support #65

Closed
gabrielittner opened this issue Mar 13, 2018 · 2 comments
Closed

Chip: dark theme support #65

gabrielittner opened this issue Mar 13, 2018 · 2 comments

Comments

@gabrielittner
Copy link

It would be great if Chip's could adapt to dark themes. Currently they still have their light grey background, dark text, and dark ripple. While it kind of works it's far from perfect and looks a bit of.

Reproduction steps

  • Use Theme.MaterialComponents or any other dark theme
  • add some chips to a layout

Version number

  • 28.0.0-alpha1

Operating system and device

  • Emulator API 27 and P
@kptlronyttcna
Copy link

It would also be great if it was possible to set custom background for different states. For example if I want to use the primary color for selected state.

@wcshi
Copy link
Contributor

wcshi commented Nov 15, 2018

@kptlronyttcna you can set a custom background for different states by using a CSL and using app:chipBackgroundColor.

@gabrielittner chip now supports dark theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants