Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing instructions for MDC-104, step 7 prevents filtering from working #145

Closed
alexandre-senecal opened this issue Jan 16, 2019 · 2 comments
Assignees

Comments

@alexandre-senecal
Copy link

The sample code to update home.dart does not pass category to the AsymetricView

In home.dart, add a variable for Category and pass it to the AsymmetricView.
...
@OverRide
Widget build(BuildContext context) {
// TODO: Pass Category variable to AsymmetricView (104)
return AsymmetricView(products: ProductsRepository.loadProducts(Category.all));
}
}

Should be replaced with

@OverRide
Widget build(BuildContext context) {
// TODO: Pass Category variable to AsymmetricView (104)
return AsymmetricView(products: ProductsRepository.loadProducts(category));
}
}

@rami-a
Copy link

rami-a commented Jan 16, 2019

Thanks for the opening the issue @alexandre-senecal, I have pushed up a change to the instructions with this fix. If you could please verify the fix, that would be great!

@rami-a rami-a self-assigned this Jan 16, 2019
@rami-a rami-a closed this as completed Jan 16, 2019
@alexandre-senecal
Copy link
Author

Looks good! Thank you @rami-a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants