Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown menu #212

Closed
lpellegr opened this issue Jan 31, 2019 · 3 comments · Fixed by #763 or #824
Closed

Dropdown menu #212

lpellegr opened this issue Jan 31, 2019 · 3 comments · Fixed by #763 or #824
Assignees
@e111077
Labels
Type: Feature New feature or request

Comments

@lpellegr
Copy link

Any short or mid-term plans for a dropdown component? It's a requirement for a lot of forms.
@aomarks aomarks added Component: Select Type: Feature New feature or request and removed Component: Select labels Aug 14, 2019
@JosefJezek
Copy link
Contributor

I am waiting also... https://github.com/material-components/material-components-web/tree/master/packages/mdc-menu

@ZufengW
Copy link

ZufengW commented Sep 13, 2019

mdc-menu is a bit different because it's not a select element.
I am also waiting for mdc-menu.

@e111077 e111077 self-assigned this Oct 1, 2019
@e111077
Copy link
Member

e111077 commented Jan 7, 2020

blocked by:

#315 #744 #745 #746

@e111077 e111077 mentioned this issue Feb 1, 2020
Merged
copybara-service bot pushed a commit that referenced this issue Feb 1, 2020
@e111077
mwc-select
0a949a4 
- Implemented:
  - `mwc-select`
  - `mwc-menu`
  - `mwc-menu-surface`
  - `mwc-list`
    - Implemented forked foundation
  - `mwc-list-item`
- Base / utils.ts
  - `isNodeElement` - performant node -> element checking
  - `deepActiveElementPath` - finds the deepest `activeElement` node
  - `doesElementContainFocus` - determines is ancestor of `activeElement`
- `mwc-radio.global` - groups radios across document rather than shadow root
- Style underline of filled textfield
  - `--mdc-text-field-idle-line-color`
  - `--mdc-text-field-hover-line-color`

Basic usage:

```html
<mwc-select outlined label="food">
  <mwc-list-item selected value="" selected></mwc-list-item>
  <mwc-list-item value="grains">
    Bread, Cereal, Rice, and Pasta
  </mwc-list-item>
  <mwc-list-item value="vegetables">Vegetables</mwc-list-item>
  <mwc-list-item value="fruit">Fruit</mwc-list-item>
</mwc-select>
```

Fixes #315
Fixes #212

FUTURE_COPYBARA_INTEGRATE_REVIEW=#763 from material-components:mwc-select 50636cb
PiperOrigin-RevId: 292662618
@copybara-service copybara-service bot mentioned this issue Feb 1, 2020
Merged
copybara-service bot pushed a commit that referenced this issue Feb 1, 2020
@e111077
mwc-select
48a8d1b 
- Implemented:
  - `mwc-select`
  - `mwc-menu`
  - `mwc-menu-surface`
  - `mwc-list`
    - Implemented forked foundation
  - `mwc-list-item`
- Base / utils.ts
  - `isNodeElement` - performant node -> element checking
  - `deepActiveElementPath` - finds the deepest `activeElement` node
  - `doesElementContainFocus` - determines is ancestor of `activeElement`
- `mwc-radio.global` - groups radios across document rather than shadow root
- Style underline of filled textfield
  - `--mdc-text-field-idle-line-color`
  - `--mdc-text-field-hover-line-color`

Basic usage:

```html
<mwc-select outlined label="food">
  <mwc-list-item selected value="" selected></mwc-list-item>
  <mwc-list-item value="grains">
    Bread, Cereal, Rice, and Pasta
  </mwc-list-item>
  <mwc-list-item value="vegetables">Vegetables</mwc-list-item>
  <mwc-list-item value="fruit">Fruit</mwc-list-item>
</mwc-select>
```

Fixes #315
Fixes #212

FUTURE_COPYBARA_INTEGRATE_REVIEW=#763 from material-components:mwc-select 50636cb
PiperOrigin-RevId: 292662618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e111077 e111077

Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mwc-select material-components/material-web
mwc-select material-components/material-web
5 participants
@aomarks @lpellegr @JosefJezek @e111077 @ZufengW