Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better readme for button #366

Merged
merged 1 commit into from Aug 14, 2019
Merged

Better readme for button #366

merged 1 commit into from Aug 14, 2019

Conversation

dfreedm
Copy link
Collaborator

@dfreedm dfreedm commented Aug 14, 2019

Related #348

e111077
e111077 approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@e111077 e111077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty pictures!

@dfreedm dfreedm merged commit 4dd027b into master Aug 14, 2019
@dfreedm dfreedm deleted the button-readme branch August 14, 2019 18:45
@stramel
Copy link

stramel commented Aug 14, 2019

Wow, nice job @azakus! 👍

@dfreedm
Copy link
Collaborator Author

dfreedm commented Aug 14, 2019

@stramel Thanks. We're going to try to do this format for all the components.

aomarks added a commit that referenced this pull request Aug 22, 2019
@aomarks
Make inner button element stretch to width of host.
3257bf0 
This regressed in the button README PR (#366).

Found because it broke our internal screenshot test which checks that
the button grows when the user sets host width.
aomarks added a commit that referenced this pull request Aug 22, 2019
@aomarks
Make inner button element stretch to width of host.
d61b4fb 
This regressed in the button README PR (#366).

Found because it broke our internal screenshot test which checks that
the button grows when the user sets host width.
@aomarks aomarks mentioned this pull request Aug 22, 2019
Merged
aomarks added a commit that referenced this pull request Aug 22, 2019
@aomarks
Make inner button element stretch to width of host. (#408)
958d1db 
This regressed in the button README PR (#366).

Found because it broke our internal screenshot test which checks that
the button grows when the user sets host width.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e111077 e111077 e111077 approved these changes

@aomarks aomarks Awaiting requested review from aomarks

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dfreedm @stramel @e111077 @googlebot