Fix broken checked property in <mwc-radio> #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we didn't trigger the SelectionController (the class that synchronizes radio button groups separated by a shadow root) when the checked property was set, so the previously checked radio in a group was not unchecked when a new one was checked. This was more complicated than just triggering it from the existing property @observer, because that gives us batched async changes (via the UpdatingElement updated callback), so we can't reconstruct the order of checked sets correctly. Replaces the observer with a setter that can handle this synchronously.
dfreedm
reviewed
Aug 15, 2019
| this.formElement.checked = checked; | ||
| }) | ||
| checked = false; | ||
| private _checked = false; |
There was a problem hiding this comment.
Should this be protected?
There was a problem hiding this comment.
Discussed offline, private makes sense for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we didn't trigger the
SelectionController(the class that synchronizes radio button groups separated by a shadow root) when the checked property was set, so the previously checked radio in a group was not unchecked when a new one was checked.This was more complicated than just triggering it from the existing property
@observer, because that gives us batched async changes (via theUpdatingElementupdated callback), so we can't reconstruct the order of checked sets correctly. Replaces the observer with a setter that can handle this synchronously.