Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 3 component "base" modules for consistency #440

Merged
merged 1 commit into from Aug 30, 2019

Conversation

aomarks
Copy link
Collaborator

@aomarks aomarks commented Aug 28, 2019

Fixes 3 exceptions to the pattern that the base module is also prefixed with mwc-:

  • icon-button-toggle-base.tsmwc-icon-button-toggle-base.ts
  • icon-button-base.tsmwc-icon-button-base.ts
  • top-app-bar-fixed-base.tsmwc-top-app-bar-fixed-base.ts

Copy link
Member

@e111077 e111077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed these in the initial review

Copy link
Collaborator

@dfreedm dfreedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aomarks aomarks merged commit 5b2ab08 into master Aug 30, 2019
@aomarks aomarks deleted the icon-base-filename branch August 30, 2019 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants