fix: Add MDCSelectFoundation.strings and missing tests (#698) (#699)

closes #698
material-components · May 23, 2017 · 8a21b4a · 8a21b4a
1 parent 171c6ec
commit 8a21b4a
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 1 deletion.
diff --git a/packages/mdc-select/foundation.js b/packages/mdc-select/foundation.js
@@ -15,7 +15,7 @@
  */
 
 import {MDCFoundation} from '@material/base';
-import {cssClasses} from './constants';
+import {cssClasses, strings} from './constants';
 import {MDCSimpleMenuFoundation} from '@material/menu';
 
 const OPENER_KEYS = [
@@ -29,6 +29,10 @@ export default class MDCSelectFoundation extends MDCFoundation {
     return cssClasses;
   }
 
+  static get strings() {
+    return strings;
+  }
+
   static get defaultAdapter() {
     return {
       addClass: (/* className: string */) => {},

diff --git a/test/unit/mdc-select/foundation.test.js b/test/unit/mdc-select/foundation.test.js
@@ -28,6 +28,10 @@ test('exports cssClasses', () => {
   assert.isOk('cssClasses' in MDCSelectFoundation);
 });
 
+test('exports strings', () => {
+  assert.isOk('strings' in MDCSelectFoundation);
+});
+
 test('default adapter returns a complete adapter implementation', () => {
   verifyDefaultAdapter(MDCSelectFoundation, [
     'addClass', 'removeClass', 'setAttr', 'rmAttr', 'computeBoundingRect',

diff --git a/test/unit/mdc-select/mdc-select.test.js b/test/unit/mdc-select/mdc-select.test.js
@@ -361,6 +361,7 @@ test(`adapter#notifyChange emits an ${strings.CHANGE_EVENT} custom event from th
   const handler = td.func('change handler');
   fixture.addEventListener(strings.CHANGE_EVENT, handler);
   component.getDefaultFoundation().adapter_.notifyChange();
+  td.verify(handler(td.matchers.anything()));
 });
 
 test('adapter#getWindowInnerHeight returns window.innerHeight', () => {

diff --git a/test/unit/mdc-tabs/mdc-tab-bar-foundation.test.js b/test/unit/mdc-tabs/mdc-tab-bar-foundation.test.js
@@ -28,6 +28,10 @@ test('exports cssClasses', () => {
   assert.isOk('cssClasses' in MDCTabBarFoundation);
 });
 
+test('exports strings', () => {
+  assert.isOk('strings' in MDCTabBarFoundation);
+});
+
 test('default adapter returns a complete adapter implementation', () => {
   verifyDefaultAdapter(MDCTabBarFoundation, [
     'addClass', 'removeClass', 'bindOnMDCTabSelectedEvent',

diff --git a/test/unit/mdc-tabs/mdc-tab-foundation.test.js b/test/unit/mdc-tabs/mdc-tab-foundation.test.js
@@ -28,6 +28,10 @@ test('exports cssClasses', () => {
   assert.deepEqual(MDCTabFoundation.cssClasses, cssClasses);
 });
 
+test('exports strings', () => {
+  assert.isOk('strings' in MDCTabFoundation);
+});
+
 test('default adapter returns a complete adapter implementation', () => {
   verifyDefaultAdapter(MDCTabFoundation, [
     'addClass', 'removeClass', 'registerInteractionHandler',