Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdc-button--theme-dark with :disabled, doesn't properly set background-color or color #1031

Closed
lynnmercier opened this issue Jul 27, 2017 · 2 comments

Comments

@lynnmercier
Copy link
Contributor

Check out the latest code and run npm run dev, navigate to http://localhost:8080/button.html (The latest version of the demo page is not available on https://material-components-web.appspot.com/button.html yet)

The mdc-theme--dark section shows a disabled button with grey text

ikgvjcpzimp

However, the mdc-button--theme-dark section shows a disabled button with black text.

b8fyn9xemo3

The second section, mdc-button--theme-dark, has the bug. The disabled button should have grey text.

The fix is to correctly use the @include mdc-theme-dark(".mdc-button") within the :disabled context of mdc-button.scss. It needs to be updated to

@include mdc-theme-dark(".mdc-button", true /* compound */)

mdc-theme-dark mixin requires $compound to be set to true if the

current selector is a compound selector with the base selector

...and :disabled is a compound selector with .mdc-button.

@bhongy
Copy link
Contributor

bhongy commented Oct 2, 2017

As of the current HEAD on master f0b607, this seems to be fixed. Screenshot below.

screen shot 2017-10-02 at 11 00 37 am

@lynnjepsen is this still an issue?

Note: anchor tag (Link) does not receive disabled style but that seems to be a separate issue.

@acdvorak
Copy link
Contributor

acdvorak commented Oct 2, 2017

Fixed by @yeelan0319.

@acdvorak acdvorak closed this as completed Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants