fix(toolbar): Fix toolbar padding on desktop and mobile #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1327 +/- ##
======================================
Coverage 99.9% 99.9%
======================================
Files 69 69
Lines 3314 3314
Branches 409 409
======================================
Hits 3311 3311
Misses 3 3Continue to review full report at Codecov.
|
kfranqueiro
suggested changes
Sep 19, 2017
packages/mdc-toolbar/_variables.scss
Outdated
| $mdc-toolbar-element-vertical-padding: 16px; | ||
| $mdc-toolbar-element-horizontal-padding-desktop: 24px; | ||
| $mdc-toolbar-element-horizontal-padding-mobile: 16px; | ||
| $mdc-toolbar-title-margin-to-icon-menu-desktop: 8px; |
There was a problem hiding this comment.
Nit: would these names read better as title-margin-to-menu-icon (rather than icon-menu)?
There was a problem hiding this comment.
It seems this won't introduce confusion with our modifier class name after offline discussion, so I am going to change it this way to make it read better.
|
Also, this should be fix(toolbar), not fix(button), I think, when we merge. |
yeelan0319
changed the title
|
Thanks for catching the commit message error! |
kfranqueiro
approved these changes
Sep 20, 2017
yeelan0319
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to guideline the padding seems not right:
https://material.io/guidelines/layout/metrics-keylines.html#metrics-keylines-keylines-spacing
After the changes, it became:
Desktop:
Mobile:
