-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(textfield): Fix textarea label from overlapping border. #1715
Conversation
Removed textarea border to prevent double borders.
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 84 84
Lines 3721 3721
Branches 484 484
=======================================
Hits 3700 3700
Misses 21 21 Continue to review full report at Codecov.
|
@@ -445,7 +445,6 @@ | |||
.mdc-text-field__input { | |||
padding: $padding-inset; | |||
padding-top: $padding-inset * 2; | |||
border: 1px solid transparent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moog16 can transparent background solve the initial problem instead of line-height? https://github.com/material-components/material-components-web/blob/master/packages/mdc-textfield/mdc-text-field.scss#L479 |
I believe the reason for the non-transparent background is so that the label is still readable in cases where the text entered into the textarea overlaps it due to overflow/scrolling. |
So a few things are being addressed in this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removed textarea border to prevent double borders.
Added line-height to textarea label.
Fixes #1608
https://www.pivotaltracker.com/story/show/153034989