feat(text-field): Move text-field outline colors to mixins #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamernest
force-pushed
the
feat/text-field/outline-box-colors-to-mixins
branch
2 times, most recently
from
78173c6
to
0f61752
Compare
lynnmercier
suggested changes
Jan 16, 2018
packages/mdc-textfield/README.md
Outdated
| @@ -210,6 +210,11 @@ Mixin | Description | |||
| `mdc-text-field-focused-bottom-line-color($color)` | Customizes the bottom-line ripple color when the text-field is focused. | |||
| `mdc-text-field-ink-color($color)` | Customizes the text entered into the text-field. | |||
| `mdc-text-field-label-color($color)` | Customizes the label color of the text-field. | |||
| `mdc-text-field-outline-stroke-color($color)` | Customizes the color of the border of the outlined text-field. | |||
There was a problem hiding this comment.
I think just mdc-text-field-outline-color. Outline is already a stroke.
Here and the two below.
packages/mdc-textfield/_mixins.scss
Outdated
| @@ -72,6 +74,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| @mixin mdc-text-field-input-hover-outline-stroke-color($color) { | |||
There was a problem hiding this comment.
Ah this took me a while to figure out....I think you should add a comment about why this is not the same as mdc-text-field-hover-outline-stroke-color. Where does this get used?
| @@ -151,7 +157,7 @@ | |||
| z-index: 2; | |||
|
|
|||
| &:hover ~ .mdc-text-field__idle-outline { | |||
| border: 1px solid $mdc-text-field-outlined-hover-border; | |||
| border: 1px solid; | |||
There was a problem hiding this comment.
Is this line necessary? Seems the same as line 136 above
There was a problem hiding this comment.
Line 136 is for the input:hover and this one is for icon:hover.
They were both set to the same color, so I set them both using the mdc-text-field-hover-outline-color.
williamernest
force-pushed
the
feat/text-field/outline-box-colors-to-mixins
branch
from
81090af
to
3e8aac1
Compare
|
CLAs look good, thanks! |
williamernest
force-pushed
the
feat/text-field/outline-box-colors-to-mixins
branch
from
3e8aac1
to
d67b586
Compare
williamernest
force-pushed
the
feat/text-field/outline-box-colors-to-mixins
branch
from
d67b586
to
625a6fd
Compare
lynnmercier
approved these changes
Jan 17, 2018
williamernest
deleted the
feat/text-field/outline-box-colors-to-mixins
branch
acdvorak
added a commit
that referenced
this pull request
Jan 17, 2018
commit f399384 Author: Andrew C. Dvorak <acdvorak@gmail.com> Date: Tue Jan 16 20:09:43 2018 -0800 chore(demos): Add example themes & load theme from URL (#1967) To test, visit the following URL: http://localhost:8080/theme/index.html?theme=dark The `theme` param must be one of `baseline`, `black`, `dark`, `white`, or `yellow`. This only works on the theme demo page; all other demo pages are unaffected. commit 1dae53c Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Tue Jan 16 19:14:54 2018 -0800 feat(text-field): Move text-field outline colors to mixins (#1963) * feat(text-field): Move color mixins for outline/helper text. Update demos/docs Breaking Change: Moves color customization of the outline text-field to SASS mixins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change: Moves color customization of the outline text-field to SASS mixins.
refs: #1526