chore(slider): remove dark theme #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2099 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 84 84
Lines 3769 3769
Branches 490 490
=======================================
Hits 3744 3744
Misses 25 25Continue to review full report at Codecov.
|
moog16
changed the title
acdvorak
suggested changes
Jan 29, 2018
acdvorak
reviewed
Jan 29, 2018
packages/mdc-slider/mdc-slider.scss
Outdated
| @include mdc-slider-highlight-color_($disabled-color); | ||
| @include mdc-slider-rail-color_($disabled-color); | ||
| @include mdc-slider-rail-tick-mark-color_($disabled-color); | ||
| @include mdc-slider-thumb-color_($disabled-color); | ||
| @include mdc-slider-thumb-stroke-cutout_($mdc-slider-default-assumed-bg-color); |
There was a problem hiding this comment.
We can remove the $mdc-slider-dark-theme-assumed-bg-color variable from _variables.scss
Don't forget to add BREAKING CHANGE to the PR description and commit message
added 5 commits
January 29, 2018 16:04
BREAKING CHANGE: removed `$mdc-slider-dark-theme-assumed-bg-color` from slider variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.