Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple: Make it possible to avoid triggering ripple for specified selectors #2358

Open
kfranqueiro opened this issue Mar 7, 2018 · 0 comments

Comments

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Mar 7, 2018

This is a follow-on from #2286, which needed to add a stopPropagation call for the time being to avoid triggering a ripple on chip elements when a specific icon within the element is clicked.

It should be possible to suppress the ripple for particular child elements to avoid the need for stopPropagation. This would ostensibly be enabled via an optional setter/API on the ripple component / foundation that receives a selector; if present, potential ripple activation events would first check whether the event target matches the given selector (queried against the root element that MDCRipple was instantiated on).

This should have no overhead for the overwhelmingly common case where this isn't used at all.

(Note that this is specifically for child elements that don't already have ripples of their own, which is already prevented in #2123 and #2178.)

@kfranqueiro kfranqueiro changed the title Ripple: Make it possible to avoid triggering ripple for certain selectors Ripple: Make it possible to avoid triggering ripple for specified selectors Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant