chore(typography): Remove the adjust margin feature #2464
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2464 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 104 104
Lines 4234 4234
Branches 534 534
=======================================
Hits 4188 4188
Misses 46 46Continue to review full report at Codecov.
|
| <div> | ||
| <input type="checkbox" id="prominent-checkbox"/> | ||
| <label for="prominent-checkbox">Prominent</label> | ||
| </div> | ||
| </div> | ||
| <div class="demo-col"> | ||
| <h4 class="mdc-typography--subheading2 mdc-typography--adjust-margin">Short Top App Bar Specific Options</h4> | ||
| <span class="mdc-typography--subheading2 demo-options-heading">Short Top App Bar Specific Options</span> |
There was a problem hiding this comment.
This change makes me realize something, related to this PR as well as the task to redefine the typography scales...
If we're going to be introducing typography scales for Headline 1-6, I would assume they're naturally going to often align with h1 to h6. These elements commonly have default margins set by the user agent, which might not be appropriate when combined with our styles. Are we sure we don't want to override those with saner defaults? Or do we think we'd override those in all cases they're used, perhaps, thus obviating the need for adjust-margin anyway?
There was a problem hiding this comment.
I think typography should only handle font properties (font-family, font-size, letter-spacing, etc) which can be displayed in any HTML element. We should not assume that @mdc-typography mixin is applied to a h3 element.
packages/mdc-typography/README.md
Outdated
| > **A note about `mdc-typography-overflow-ellipsis`**, `mdc-typography-overflow-ellipsis` should only be used if the element is `display: block` or `display: inline-block`. | ||
|
|
||
| #### `$style` Values | ||
|
|
||
| These styles can be used as the `$style` argument for `mdc-typography` and `mdc-typography-adjust-margin` mixins. | ||
| These styles can be used as the `$style` argument for `mdc-typography` mixins. |
There was a problem hiding this comment.
Fix wording: These styles can be used as the $style argument for the mdc-typography mixin.
BREAKING CHANGE: Removes the `mdc-typography--adjust-margin` CSS class and the `mdc-typography-adjust-margin` Sass mixin
Fixes #2463