feat(fab): Add support for svg icons #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2504 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 104 104
Lines 4226 4226
Branches 530 530
=======================================
Hits 4168 4168
Misses 58 58Continue to review full report at Codecov.
|
kfranqueiro
suggested changes
Apr 6, 2018
packages/mdc-fab/README.md
Outdated
| @@ -57,6 +57,8 @@ We recommend you load [Material Icons](https://material.io/icons/) from Google F | |||
| </button> | |||
| ``` | |||
|
|
|||
| > _NOTE:_ The floating action button icon can be used with a `span`, `a`, `img`, `i`, or `svg` element. | |||
There was a problem hiding this comment.
Remove a (doesn't make sense inside a button) and move img after i
packages/mdc-fab/_mixins.scss
Outdated
| @@ -38,6 +38,14 @@ | |||
| @include mdc-theme-prop(background-color, $color, $edgeOptOut: true); | |||
| } | |||
|
|
|||
| @mixin mdc-fab-icon-size($width: 24px, $height: $width) { | |||
There was a problem hiding this comment.
Don't default width here; specify it below in mdc-fab.scss
Also, this needs to be documented in the README. I'd probably lump it under advanced sass mixins.
kfranqueiro
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2502