Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chips): Customize icon size and color #2613

Merged
merged 9 commits into from
Apr 20, 2018
Merged

Conversation

bonniezhou
Copy link
Contributor

@bonniezhou bonniezhou commented Apr 20, 2018

  • Make leading and trailing icon sizes customizable individually
  • Update the default leading icon size to 20px
  • Make leading and trailing icon colors customizable individually (with optional params for opacity)
  • Set icon colors in mdc-chip-fill-color-accessible mixin

Fixes #2484

@codecov-io
Copy link

codecov-io commented Apr 20, 2018

Codecov Report

Merging #2613 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2613   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          98       98           
  Lines        4230     4230           
  Branches      537      537           
=======================================
  Hits         4166     4166           
  Misses         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639387e...9fd2baf. Read the comment docs.

@bonniezhou bonniezhou changed the title feat(chips): Customize icon size feat(chips): Customize icon size and color Apr 20, 2018
`mdc-chip-leading-icon-color($color, $opacity)` | Customizes the color of a leading icon in a chip, optionally customizes opacity
`mdc-chip-trailing-icon-color($color, $opacity, $hover-opacity, $focus-opacity)` | Customizes the color of a trailing icon in a chip, optionally customizes regular/hover/focus opacities
`mdc-chip-leading-icon-size($size)` | Customizes the size of a leading icon in a chip
`mdc-chip-trailing-icon-color($size)` | Customizes the size of a trailing icon in a chip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be -size I guess?

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo in readme, otherwise lgtm

@bonniezhou bonniezhou merged commit 0f5af21 into master Apr 20, 2018
@kfranqueiro kfranqueiro deleted the fix/chips/icon branch April 21, 2018 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants