-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for "mdc-icon-button" #2673
Comments
Should this be it's own package? It sounds like it should just be added as a variant to the current |
It wouldn't really have any styles in common with button, though, I suppose? Though I guess it'd basically be like flat button but with unbounded ripple instead... I am worried about naming this clearly to avoid confusion with an actual icon-only MDC Button if that also becomes a thing, though. I am wondering whether this warrants being its own component or if it's overkill, if all it's ostensibly doing is applying ink color + states and adding a set padding. |
The entire package is ~40 lines of scss. It seems like it's just a variant of https://gist.github.com/williamernest/d852281e711f4f10bd2ef255cc518885 |
Looks like it'll stand as variant of Added to tracker. |
We're condensing this and |
Can we pull the "navigation icon" and "action item" out of mdc-top-app-bar and into it's own "mdc-icon-button" component?
Having a button which triggers an unbounded ripple is useful on it's own.
The text was updated successfully, but these errors were encountered: