Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for "mdc-icon-button" #2673

Closed
lynnmercier opened this issue Apr 27, 2018 · 5 comments · Fixed by #2748
Closed

Request for "mdc-icon-button" #2673

lynnmercier opened this issue Apr 27, 2018 · 5 comments · Fixed by #2748
Labels

Comments

@lynnmercier
Copy link
Contributor

Can we pull the "navigation icon" and "action item" out of mdc-top-app-bar and into it's own "mdc-icon-button" component?

Having a button which triggers an unbounded ripple is useful on it's own.

@williamernest
Copy link
Contributor

Should this be it's own package? It sounds like it should just be added as a variant to the current mdc-button

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Apr 27, 2018

It wouldn't really have any styles in common with button, though, I suppose? Though I guess it'd basically be like flat button but with unbounded ripple instead...

I am worried about naming this clearly to avoid confusion with an actual icon-only MDC Button if that also becomes a thing, though.

I am wondering whether this warrants being its own component or if it's overkill, if all it's ostensibly doing is applying ink color + states and adding a set padding.

@williamernest
Copy link
Contributor

The entire package is ~40 lines of scss. It seems like it's just a variant of button with an unbounded ripple.

https://gist.github.com/williamernest/d852281e711f4f10bd2ef255cc518885

@bonniezhou
Copy link
Contributor

bonniezhou commented Apr 30, 2018

Looks like it'll stand as variant of button, i.e. mdc-button--icon.
(We've also decided that mdc-button--icon with nested mdc-button__icon is not awkward at all.)

Added to tracker.

@williamernest
Copy link
Contributor

We're condensing this and icon-toggle into their own mdc-icon-button package. The icon button had ripple conflicts with button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants