Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-field): Moved VALIDATION_ATTR_WHITELIST to constants. #2808

Merged
merged 1 commit into from
May 24, 2018

Conversation

abhiomkar
Copy link
Contributor

No description provided.

@abhiomkar abhiomkar requested a review from moog16 May 24, 2018 18:53
@codecov-io
Copy link

codecov-io commented May 24, 2018

Codecov Report

Merging #2808 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2808   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          98       98           
  Lines        4232     4232           
  Branches      538      538           
=======================================
  Hits         4168     4168           
  Misses         64       64
Impacted Files Coverage Δ
packages/mdc-textfield/foundation.js 98.88% <ø> (-0.01%) ⬇️
packages/mdc-textfield/constants.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4562394...623e7ff. Read the comment docs.

@kfranqueiro kfranqueiro force-pushed the fix_textfield_constants_issue2717 branch from 4450661 to 623e7ff Compare May 24, 2018 19:16
Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Are you doing the React fix? I saw a card with your name on it. Can you please remember/document to use this whitelist?

@abhiomkar
Copy link
Contributor Author

Yes, I'm doing React fix followed by this change. We don't need to use this constant in React anymore because the new handleAttributeChange change will do that for us. :)

@abhiomkar abhiomkar merged commit 2180f95 into master May 24, 2018
@kfranqueiro kfranqueiro deleted the fix_textfield_constants_issue2717 branch May 31, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants