fix(icon-button): Remove unused styles and update docs #2957
Conversation
williamernest
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2957 +/- ##
=========================================
- Coverage 98.3% 98.3% -0.01%
=========================================
Files 101 101
Lines 4375 4368 -7
Branches 564 564
=========================================
- Hits 4301 4294 -7
Misses 74 74
Continue to review full report at Codecov.
|
williamernest
force-pushed
the
fix/icon-button/remove-unused-styles
branch
from
0ea9ec0
to
c1c5714
Compare
| @@ -23,10 +23,4 @@ | |||
| @include mdc-states; | |||
| } | |||
|
|
|||
| .mdc-icon-button--disabled { | |||
There was a problem hiding this comment.
Should this be replaced with a :disabled selector instead of removed completely?
There was a problem hiding this comment.
The :disabled selector is in the mixins file. This was left over from icon-toggle and was used when the icon-toggle was on an element other than a button (span, div, etc). We dropped support for everything except for button and a tags, so this is no longer needed at all. Like mdc-button you can use :disabled for button elements to disable them. Anchor tags don't support disabled at all.
There was a problem hiding this comment.
Sweet, thanks for explaining!
Address: #2918
Also, fixes a bug where the foundation was always initializing as 'off'.