Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): Update clickable elements selector #3312

Merged
merged 3 commits into from
Aug 8, 2018

Conversation

williamernest
Copy link
Contributor

Updates the enabled items selector to search for descendant elements of .mdc-list-item instead of all a and button elements.

Updates Readme demo to show tabindex=0 for the first element that should be in tab order for single selection lists.

Updates the list component to default to vertical list if aria-orientation is not present or is misspelled.

Adds unit test for instantiating the component with various aria-orientation values.

@mdc-web-bot
Copy link
Collaborator

All 188 screenshot tests passed for commit 93c8546 vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #3312 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3312   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         120      120           
  Lines        5184     5184           
  Branches      649      649           
=======================================
  Hits         5082     5082           
  Misses        102      102
Impacted Files Coverage Δ
packages/mdc-list/constants.js 100% <ø> (ø) ⬆️
packages/mdc-list/index.js 98.78% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 791b668...6c31158. Read the comment docs.

Copy link
Contributor

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mdc-web-bot
Copy link
Collaborator

All 188 screenshot tests passed for commit 6c31158 vs. master! 💯🎉

@williamernest williamernest merged commit c8ded0a into master Aug 8, 2018
@williamernest williamernest deleted the fix/list/update-clickable-elements-selector branch August 8, 2018 16:38
YuoMamoru pushed a commit to YuoMamoru/material-components-web that referenced this pull request Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants