Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Menu: Don't suppress scrollbars while animating #3323

Closed
kfranqueiro opened this issue Aug 9, 2018 · 0 comments · Fixed by #3358
Closed

New Menu: Don't suppress scrollbars while animating #3323

kfranqueiro opened this issue Aug 9, 2018 · 0 comments · Fixed by #3358
Labels

Comments

@kfranqueiro
Copy link
Contributor

A long time ago, the old "Simple" Menu used to do some height acrobatics when animating open. This led to scrollbars potentially appearing while the menu was animating open, which in turn led to this fix.

Since we redesigned the menu, this is no longer an issue since we no longer animate heights. However, we're currently still suppressing scrollbars, which leads to odd snap-in effects when the menu finishes its opening transitions. We should probably stop suppressing the scrollbar during opening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant