fix(drawer): Modal --open state class needs display: flex #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All 349 screenshot tests passed for commit c66e05b vs. |
|
All 349 screenshot tests passed for commit e96c125 vs. |
|
All 349 screenshot tests passed for commit f2a6ec2 vs. |
|
To further clarify, this fixes a bug where header content in the drawer would seem to push the bottom of the drawer's list content down and off of the viewport in cases where there's enough content to scroll. |
kfranqueiro
reviewed
Aug 28, 2018
packages/mdc-drawer/README.md
Outdated
| @@ -319,6 +319,7 @@ Mixin | Description | |||
| `mdc-drawer-item-corner-radius($radius)` | Sets the corner border radius of the drawer list item. | |||
| `mdc-drawer-activated-overlay-color($color)` | Sets the overlay color of the activated drawer list item. | |||
| `mdc-drawer-scrim-fill-color($color)` | Sets the fill color of `mdc-drawer-scrim`. | |||
| `mdc-drawer-z-index($value)` | Sets the z index of drawer. Drawer stays on top of top app bar except for clipped variant of drawer. | |||
There was a problem hiding this comment.
This seems like it should be in a separate feat(drawer) PR. Can we isolate just the mdc-drawer-modal.scss change for this PR?
kfranqueiro
approved these changes
Aug 29, 2018
|
All 349 screenshot tests passed for commit 3fc1859 vs. |
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Sep 25, 2018
…omponents#3431) (cherry picked from commit 533a46f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
display: flexon--openstate supports__contentto be scrollable.Fixes #3465