Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dom): Add closest ponyfill #3559

Merged
merged 2 commits into from
Sep 18, 2018
Merged

feat(dom): Add closest ponyfill #3559

merged 2 commits into from
Sep 18, 2018

Conversation

kfranqueiro
Copy link
Contributor

Fixes #3536.

I used td for unit tests since otherwise running them locally shows a huge gap (since Chrome supports native closest so the entire other branch never gets hit).

This was referenced Sep 13, 2018
Closed
Merged
@kfranqueiro kfranqueiro requested review from abhiomkar and removed request for williamernest September 18, 2018 15:49
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@eadde7a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3559   +/-   ##
========================================
  Coverage          ?   98.4%           
========================================
  Files             ?     120           
  Lines             ?    5067           
  Branches          ?     629           
========================================
  Hits              ?    4986           
  Misses            ?      81           
  Partials          ?       0
Impacted Files Coverage Δ
packages/mdc-dom/ponyfill.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eadde7a...d0d7222. Read the comment docs.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@eadde7a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3559   +/-   ##
=========================================
  Coverage          ?   98.42%           
=========================================
  Files             ?      120           
  Lines             ?     5131           
  Branches          ?      636           
=========================================
  Hits              ?     5050           
  Misses            ?       81           
  Partials          ?        0
Impacted Files Coverage Δ
packages/mdc-dom/ponyfill.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eadde7a...d0d7222. Read the comment docs.

2 similar comments
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@eadde7a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3559   +/-   ##
=========================================
  Coverage          ?   98.42%           
=========================================
  Files             ?      120           
  Lines             ?     5131           
  Branches          ?      636           
=========================================
  Hits              ?     5050           
  Misses            ?       81           
  Partials          ?        0
Impacted Files Coverage Δ
packages/mdc-dom/ponyfill.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eadde7a...d0d7222. Read the comment docs.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@eadde7a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3559   +/-   ##
=========================================
  Coverage          ?   98.42%           
=========================================
  Files             ?      120           
  Lines             ?     5131           
  Branches          ?      636           
=========================================
  Hits              ?     5050           
  Misses            ?       81           
  Partials          ?        0
Impacted Files Coverage Δ
packages/mdc-dom/ponyfill.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eadde7a...d0d7222. Read the comment docs.

@kfranqueiro kfranqueiro merged commit eddf66c into master Sep 18, 2018
@kfranqueiro kfranqueiro deleted the feat/dom-closest branch September 18, 2018 22:35
@jamesmfriedman jamesmfriedman mentioned this pull request Sep 26, 2018
Closed
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiomkar abhiomkar abhiomkar approved these changes

Assignees

@abhiomkar abhiomkar

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add closest ponyfill to mdc-dom package
5 participants
@kfranqueiro @codecov-io @abhiomkar @googlebot @williamernest