fix(list): Always call followHref regardless of single-selection mode #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3595 +/- ##
==========================================
+ Coverage 98.35% 98.35% +<.01%
==========================================
Files 120 120
Lines 5175 5176 +1
Branches 642 643 +1
==========================================
+ Hits 5090 5091 +1
Misses 85 85
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this issue while attempting some approaches for lists in dialogs.
Currently, if single-selection mode isn't enabled, links don't get followed. I'm pretty sure they ought to be followed regardless.
I also noticed another test was accidentally testing the enter key twice instead of enter and space.