feat(dialog): Support default action button #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
force-pushed
the
feat/dialog-default-action
branch
from
f85f796
to
7d2e8c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #3600 +/- ##
==========================================
+ Coverage 98.43% 98.43% +<.01%
==========================================
Files 120 120
Lines 5182 5192 +10
Branches 645 649 +4
==========================================
+ Hits 5101 5111 +10
Misses 81 81
Continue to review full report at Codecov.
|
|
All 545 screenshot tests passed for commit 621065d vs. |
|
All 557 screenshot tests passed for commit 6416429 vs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3593.
Implements default action via a CSS modifier class that can be added to one of the buttons in the actions area of the dialog. If present, pressing enter while focused in the dialog will equate to clicking that button, unless:
clickdoes nothing)This can be tested live via the baseline-confirmation screenshot test page.
This adds an adapter API and changes another, but this is already encompassed under the general breaking change note for the new Dialog implementation.