fix(fab): Separate mixins for regular FAB and Extended FAB #4082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
reviewed
Nov 13, 2018
|
|
||
| @mixin mdc-fab-extended-shape-radius($radius, $rtl-reflexive: false) { |
There was a problem hiding this comment.
Is the &.mdc-fab--extended selector now redundant since this is only expected to be used within that context?
There was a problem hiding this comment.
Makes sense.
Also, added not() selector for regular/mini fab variant so extended variant don't get extra styles.
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>extended-padding FAB Mixin - MDC Web Screenshot Test</title> |
There was a problem hiding this comment.
Update titles in new screenshot test pages
kfranqueiro
approved these changes
Nov 13, 2018
kfranqueiro
reviewed
Nov 13, 2018
|
🤖 Beep boop! Screenshot test report 🚦8 screenshots changed from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Fab now has 2 separate mixins -
mdc-fab-shape-radiusfor regular & mini Fab variants &mdc-fab-extended-shape-radiusfor Extended FAB variant.Before:
After:
Where,
mdc-fab-shape-radiusdoesn't resolve percentage to absolute value.mdc-fab-shape-radiussets rounded shape to regular & mini FAB.mdc-fab-extended-shape-radiussets rounded shape to only Extended FAB.Fixes #3989