Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio): add feature targeting for styles #4270

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

mmalerba
Copy link
Collaborator

This PR adds Sass feature targeting to the checkbox component as part of #4227.

Currently blocked on #4228 which adds the mdc-feature-targeting package.

@mmalerba
Copy link
Collaborator Author

mmalerba commented Jan 18, 2019

I merged some target blocks that were clearly safe to merge, so the emitted CSS diff is not exactly the same. I sanity checked it though and it looks good

@codecov-io
Copy link

codecov-io commented Jan 18, 2019

Codecov Report

Merging #4270 into master will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4270      +/-   ##
==========================================
+ Coverage   98.58%   98.91%   +0.33%     
==========================================
  Files         127      127              
  Lines        5705     5705              
  Branches      762      762              
==========================================
+ Hits         5624     5643      +19     
+ Misses         81       62      -19
Impacted Files Coverage Δ
packages/mdc-checkbox/index.js 100% <0%> (+1.2%) ⬆️
packages/mdc-ripple/index.js 100% <0%> (+2.08%) ⬆️
packages/mdc-auto-init/index.js 100% <0%> (+2.77%) ⬆️
packages/mdc-tab/index.js 96.49% <0%> (+3.5%) ⬆️
packages/mdc-ripple/util.js 100% <0%> (+3.5%) ⬆️
packages/mdc-base/component.js 100% <0%> (+4.16%) ⬆️
packages/mdc-switch/index.js 97.95% <0%> (+6.12%) ⬆️
packages/mdc-tabs/tab/index.js 100% <0%> (+9.09%) ⬆️
packages/mdc-radio/index.js 97.43% <0%> (+12.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed492c...5c20ea2. Read the comment docs.

@mmalerba mmalerba force-pushed the radio-sass branch 2 times, most recently from 6eead0a to ed2e5df Compare January 18, 2019 23:27
@kfranqueiro kfranqueiro merged commit eb8b8f6 into material-components:master Jan 25, 2019
@kfranqueiro
Copy link
Contributor

LGTM to me as well, and the radio screenshot tests show no changes. Thanks!

@jamesmfriedman jamesmfriedman mentioned this pull request Feb 5, 2019
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants